Guard snapshot process signals in GUI#2457
Conversation
buhtz
added
the
PR: Waiting for review
|
Hello Ajeem, thank you for your contribution and taking time to improve Back In Time. I appreciate it. On a quick initial review your PR looks good. I'll review it in detail later. Please note that currently I have to put all PRs on hold, because the Back In Time code base is in a transition phase. I am rewriting the mounting subsystem from scratch (PR #2449). Since the components are not well isolated, this affects nearly every file. To avoid complex merge conflicts, all other PRs are temporarily on hold. Best wishes, |
|
The new mount subsystem is read for testing incl. full gocryptfs support as encfs replacement. |
There was a problem hiding this comment.
Hello Ajeem,
I like your solution and just have some minor suggestions on it.
The big blocking PR was merged, so we can now proceed further with your PRs. I hope you are still with me.
Please note that I have updated your branch. So you have to pull/fetch first.
Regards,
Christian
| if not tools.processAlive(pid): | ||
| self._update_backup_status(True) | ||
| return False |
There was a problem hiding this comment.
If you don't have any objects, I suggest to remove that part.
The following try-except-block is enough for this rare case.
| logger.debug( | ||
| f'Ignoring signal {sig} for vanished snapshot process {pid}.') |
There was a problem hiding this comment.
No need for debug output on this event.
buhtz
added
Feedback
|
Hello Ajeem, can you please give me a life sign and explain your plans with this PR. Best, |
|
Hi, this PR has been inactive for several months. I have provided feedback and suggested changes, but there has been no response or update from your side. Please be aware that maintaining and completing the proposed changes is the responsibility of the PR author. I will not take over the implementation work. If you want this PR to be merged, please continue the discussion, address the review comments, and update the PR. Otherwise, I will close this PR without merging it. Thank you. |
2 participants
Summary:
Prevent a GUI crash when pause, resume, or stop is clicked after the snapshot process has already disappeared on a slow system.
What changed:
Testing:
Closes #1604